June 25th, 2019

(no subject)

Regarding the code in the middle:
- first, if you ran a regex that expects a number, and you captured that number, then why are you checking that it’s not null?
- second, if cacheVersion (which is a number) does not equal version (also a number, which happens to start at 1 and increment by 1 every now and then), then why do you care whether it’s equal to 0? why the noise?

(And he also ran a map entirely for side-effecty purpose; instead of forEach. Every time I see it, and I see it far too often than I would like, I lose my shit.)